Did you really expect gun rights legislation passed in the first two years? I think that was a bunch of wishful thinking. Even if Trump would sign it, I think either Ryan or McConnell were against it. I would have liked to see more effort in reducing the processing time in the ATF and maybe some executive level changes on imports, but I am happy with what was done on other issues.
Trump still hasn't even gotten all his appointments approved. I think the high expectations is why midterm elections generally go against the party with the President in office.
If not in the first two years with a majority, then when? While I am also happy with much of what Trump has done, and recognize that it is stuff that affects many more Americans than gun owners, that's kinda the point.
We gun owners are not as important in the scheme of things as we think we are. If gun rights legislation can't get passed when the administration and majority are "riding high", the probability of anything getting done drops like a 1920s stock market. Unless by some miracle, R's get even more seats in the house and senate today, significant pro-gun legislation is likely done for the next two years. We might be able to hold back anti-gun legislation, but even that's not guaranteed since Trump had no problems with bump stock bans after Vegas.
With a D majority, Trump will be spending all his time in the next two years trying to save his economic agenda, which is probably the smart use of resources. Then he might take on health care again. Gun stuff will be well down the list.