Hyphens still have their place, though. That place is for immigrants. Someone who is Scottish and has immigrated to America is a Scottish-America. Preacherman is African-American (although that opens a further debate about "African" vs. South African/Nigerian/Egyptian, which I suppose means "African-American" still is a bad idea.)
